Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix published dataset datablocks and attachments permissions #354

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix published dataset datablocks and attachments permissions #354

merged 1 commit into from
Feb 28, 2023

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Feb 23, 2023 •
edited
Loading

Description

Fix permissions for following endpoints:

  • GET /datasets/:id/thumbnail
  • GET /datasets/:id/origdatablocks
  • GET /datasets/:id/datablocks
  • GET /datasets/:id/attachments

Motivation

The above endpoints were not allowing unauthenticated user to access data on public datasets.

Fixes:

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@martin-trajanovski martin-trajanovski mentioned this pull request Feb 24, 2023
Merged
@martin-trajanovski martin-trajanovski marked this pull request as ready for review February 24, 2023 06:24
@nitrosx nitrosx merged commit 1ba4de0 into master Feb 28, 2023
@nitrosx nitrosx deleted the SWAP-3084-published-dataset-datablock-permissions branch February 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrosx nitrosx nitrosx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-trajanovski @nitrosx