Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing ApiProperty decorator to patchExternalSettings endpoint #1670

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: add missing ApiProperty decorator to patchExternalSettings endpoint #1670

merged 1 commit into from
Jan 28, 2025

Conversation

Junjiequan
Copy link
Member

Description

  • Added the missing ApiProperty decorator for the patchExternalSettings endpoint.
  • Rearranged comment sequence to ensure the commit message is on the first line of the class for auto-generating schema decorators.

Motivation

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@Junjiequan Junjiequan merged commit 8ac01ba into master Jan 28, 2025
13 checks passed
@Junjiequan Junjiequan deleted the SWAP-4363-scicat-user-settings-patch-do-not-work-with-new-s branch January 28, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-trajanovski martin-trajanovski martin-trajanovski approved these changes

@emigun emigun Awaiting requested review from emigun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Junjiequan @martin-trajanovski