Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make large file access warning text configurable with largeData… #1517

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

Junjiequan
Copy link
Member

…FileAccessInstruction.

Description

Change for the SciCatProject/frontend#1666

Motivation

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@Junjiequan Junjiequan marked this pull request as ready for review November 20, 2024 14:18
@Junjiequan Junjiequan force-pushed the SWAP-4247-change-sftp-text-on-scicat branch 3 times, most recently from b959770 to 1428273 Compare November 29, 2024 17:58
CI/E2E/frontend.config.json Outdated Show resolved Hide resolved
src/config/frontend.config.json Show resolved Hide resolved
@Junjiequan Junjiequan force-pushed the SWAP-4247-change-sftp-text-on-scicat branch from 734e2c0 to 876483b Compare January 8, 2025 09:47
@Junjiequan Junjiequan requested a review from nitrosx January 8, 2025 09:47
@Junjiequan Junjiequan force-pushed the SWAP-4247-change-sftp-text-on-scicat branch 2 times, most recently from 1477788 to 1bc05f2 Compare January 8, 2025 13:38
@Junjiequan Junjiequan force-pushed the SWAP-4247-change-sftp-text-on-scicat branch 2 times, most recently from 74015bc to e4ac8c5 Compare January 13, 2025 08:25
@Junjiequan Junjiequan force-pushed the SWAP-4247-change-sftp-text-on-scicat branch from e4ac8c5 to 2dccd33 Compare January 16, 2025 09:38
@Junjiequan Junjiequan force-pushed the SWAP-4247-change-sftp-text-on-scicat branch from 2dccd33 to f33449f Compare January 17, 2025 11:56
@Junjiequan Junjiequan enabled auto-merge (squash) January 17, 2025 11:56
@Junjiequan Junjiequan merged commit 55fb2fd into master Jan 17, 2025
13 checks passed
@Junjiequan Junjiequan deleted the SWAP-4247-change-sftp-text-on-scicat branch January 17, 2025 12:06
Junjiequan added a commit that referenced this pull request Jan 22, 2025
#1517)

…FileAccessInstruction.

<!--
Follow semantic-release guidelines for the PR title, which is used in
the changelog.

Title should follow the format `<type>(<scope>): <subject>`, where
- Type is one of:
build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|BREAKING
CHANGE
- Scope (optional) describes the place of the change (eg a particular
milestone) and is usually omitted
- subject should be a non-capitalized one-line description in present
imperative tense and not ending with a period

See
https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines
for more details.
-->

## Description
Change for the SciCatProject/frontend#1666

## Motivation
<!-- Background on use case, changes needed -->

## Fixes
<!-- Please provide a list of the issues fixed by this PR -->

* Bug fixed (#X)

## Changes:
<!-- Please provide a list of the changes implemented by this PR -->

* changes made

## Tests included

- [ ] Included for each change/fix?
- [ ] Passing? <!-- Merge will not be approved unless tests pass -->

## Documentation
- [ ] swagger documentation updated (required for API changes)
- [ ] official documentation updated

### official documentation info
<!-- If you have updated the official documentation, please provide PR #
and URL of the updated pages -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants