fix: prevent empty string pushed into the accessGroups

SciCatProject · May 1, 2024 · 857530a · 857530a
1 parent 7fad4b5
commit 857530a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/auth/access-group-provider/access-group-from-multiple-providers.service.ts b/src/auth/access-group-provider/access-group-from-multiple-providers.service.ts
@@ -17,8 +17,12 @@ export class AccessGroupFromMultipleProvidersService extends AccessGroupService
     for (const accessGroupProvider of this.accessGroupProviders) {
       const accessGroupsFromProvider =
         await accessGroupProvider.getAccessGroups(userPayload);
-      accessGroups.push(...accessGroupsFromProvider);
+
+      accessGroups.push(
+        ...accessGroupsFromProvider.filter((group) => group.trim() !== ""),
+      );
     }
+
     return accessGroups;
   }
 }
diff --git a/src/config/configuration.ts b/src/config/configuration.ts
@@ -86,10 +86,7 @@ const configuration = () => {
     },
     accessGroupsStaticConfig: {
       enabled: boolean(process.env?.ACCESS_GROUPS_STATIC_ENABLED || true),
-      value:
-        (accessGroupsStaticValues &&
-          accessGroupsStaticValues.split(",").map((v) => v.trim())) ??
-        [],
+      value: accessGroupsStaticValues.split(",").map((v) => v.trim()) ?? [],
     },
     accessGroupsOIDCPayloadConfig: {
       enabled: boolean(process.env?.ACCESS_GROUPS_OIDCPAYLOAD_ENABLED || false),