Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parent proposal to a proposal #1655

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Nov 12, 2024

Description

This PR aims to show the parent proposal in the proposal details view and also test the functionality with the e2e tests.

Motivation

There was a feature requested to add new field on a proposal called parent proposal and it needs to be shown in the proposal details page

Fixes:

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Add functionality to display parent proposals in the proposal detail view and update the proposal fetching logic to encode proposal IDs for API access. Update Swagger documentation and include end-to-end tests for the new feature.

New Features:

  • Introduce functionality to fetch and display parent proposals in the proposal detail view.

Enhancements:

  • Enhance proposal fetching logic by encoding proposal IDs to ensure proper API access.

Documentation:

  • Update Swagger documentation to reflect the new parent proposal feature.

Tests:

  • Add end-to-end tests to verify the functionality of displaying parent proposals in the proposal detail view.

@martin-trajanovski martin-trajanovski marked this pull request as ready for review November 13, 2024 10:09
@martin-trajanovski martin-trajanovski self-assigned this Nov 13, 2024
@martin-trajanovski martin-trajanovski added feature DCS DAPHNE Contribution to SciCat labels Nov 13, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martin-trajanovski - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 2 issues found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/app/state-management/effects/proposals.effects.ts Outdated Show resolved Hide resolved
cypress/support/commands.js Show resolved Hide resolved
src/app/state-management/effects/proposals.effects.ts Outdated Show resolved Hide resolved
@martin-trajanovski martin-trajanovski merged commit 852580a into master Nov 15, 2024
6 checks passed
@martin-trajanovski martin-trajanovski deleted the SWAP-4298-parent-proposal branch November 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants