Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed sdk local generation for linux #1644

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

nitrosx
Copy link
Member

@nitrosx nitrosx commented Nov 5, 2024

Description

Fix sdk generation in local development environment

Motivation

While testing the feature, the autogeneration did not worked in a linux environment.
This PR ensures that the local sdk autogeneration works on Linux.
We will need to test it in a window environment.

Fixes:

  • scripts/generate-nestjs-sdk.js

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked) Tested manually

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

Summary by Sourcery

Bug Fixes:

  • Fix SDK generation script to work in Linux environments by adjusting Docker volume mounting and host configuration.

@nitrosx nitrosx added bug DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK labels Nov 5, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nitrosx - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please verify and confirm this change works in Windows environments before merging, as the path format has changed from Windows-style to Unix-style
  • The swagger documentation update is marked as required but hasn't been completed - please update accordingly
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nitrosx nitrosx merged commit 729a735 into new-sdk-release Nov 6, 2024
2 checks passed
@nitrosx nitrosx deleted the fix-sdk-local-generation branch November 6, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants