Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust types after using the new sdk #1636

Merged

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Nov 1, 2024

Description

This PR contains two major changes:

  1. Removal of the old auto-generated sdk
  2. Adjustments of the types according the new sdk

Motivation

The old sdk was generated towards the old loopback api and it wasn't relevant anymore. The new one gives better feedback and reflects the changes from the backend.

Changes:

Please provide a list of the changes implemented by this PR

  • most important changes are that we remove a lot of code that was obsolete in the codebase and it is replaced by smaller but more relevant chunks

Documentation

  • it will be updated in the next PR where we auto-generate the sdk

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

@nitrosx nitrosx added DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK labels Nov 1, 2024
Copy link
Member

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Testing out locally on my machine

@nitrosx nitrosx merged commit 04f5ac1 into new-sdk-release Nov 5, 2024
2 checks passed
@nitrosx nitrosx deleted the SWAP-4278-new-sdk-frotnend-code-refactor-part-2 branch November 5, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat Release New SDK Refactoring FE to use autogenerated SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants