Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: decouple default search UI interface logic from backend #1578

Conversation

Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented Sep 4, 2024

Description

This PR aims to separate frontend configuration from the backend, making the frontend more autonomous and reducing backend dependencies.

NOTE: Once its merged, tests need to be modified.

Motivation

To improve flexibility and maintainability while reducing unnecessary backend dependencies.

Changes:

  • Replaced references to localColumns with defaultDatasetsListSettings.columns with backward compatibility .
  • Added defaultDatasetsListSettings to AppConfig for default filters, columns, and conditions in the dataset list.
  • Introduced labelMaps to store filter labels in AppConfig. If not provided, fallback to component.instance.label.
  • Removed get default settings endpoint.

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

@Junjiequan Junjiequan changed the base branch from master to load-user-defaults-from-be September 4, 2024 15:56
@Junjiequan Junjiequan changed the title Decouple default search UI interface logic from backend refactor: decouple default search UI interface logic from backend Sep 4, 2024
@Junjiequan Junjiequan marked this pull request as ready for review September 5, 2024 08:48
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@nitrosx nitrosx merged commit 9f46188 into load-user-defaults-from-be Sep 19, 2024
2 of 3 checks passed
@nitrosx nitrosx deleted the decouple-default-search-UI-interface-logic-from-backend branch September 19, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants