Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show release version and site on user settings page #1486

Merged

Conversation

Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented May 29, 2024

Description

Updated the application version and improved user settings display.

image

Motivation

Enhance user experience by displaying the current app version and facility site information in the user settings.

Changes:

  • Updated app version to 4.4.0. in package.json
  • Displayed appVersion and facility in user settings.
  • Enabled JSON module resolution in TypeScript configuration.

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

@Junjiequan Junjiequan requested review from bpedersen2 and nitrosx May 29, 2024 08:36
@Junjiequan Junjiequan enabled auto-merge (squash) May 29, 2024 09:12
@Junjiequan Junjiequan force-pushed the SWAP-4038-scicat-fe-on-user-settings-page-replace-data-jo branch from e13cd59 to 800c5a0 Compare May 29, 2024 09:12
<th>Dataset Count</th>
<td>{{ value }}</td>
<tr *ngIf="appVersion">
<th>Release Version</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to Frontend Release Version?

@Junjiequan Junjiequan requested a review from nitrosx May 30, 2024 11:13
@Junjiequan Junjiequan force-pushed the SWAP-4038-scicat-fe-on-user-settings-page-replace-data-jo branch from 0b18ba9 to c6c70be Compare May 30, 2024 12:28
@Junjiequan Junjiequan force-pushed the SWAP-4038-scicat-fe-on-user-settings-page-replace-data-jo branch from c6c70be to 1285101 Compare June 4, 2024 08:41
@Junjiequan Junjiequan merged commit a5c568f into master Jun 4, 2024
6 checks passed
@Junjiequan Junjiequan deleted the SWAP-4038-scicat-fe-on-user-settings-page-replace-data-jo branch June 4, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants