Explicit action button search facets #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting
2 tasks
Ingvord
changed the title
|
Looks like this one also catches some non related commits. Have no idea how to solve that... |
nitrosx
approved these changes
Apr 19, 2024
…acets # Conflicts: # src/app/datasets/dashboard/dashboard.component.html # src/app/datasets/dashboard/dashboard.component.scss # src/app/datasets/dashboard/dashboard.component.ts
Junjiequan
pushed a commit
that referenced
this pull request
May 21, 2024
* Change label * Add button * Add button * Full width search bar (#1426) * First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting * Fix layout * Add functionality to the button
Junjiequan
added a commit
that referenced
this pull request
May 21, 2024
) * Full width search bar (#1426) * First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting * Separating full text search from shared search bar * Add search and clear buttons; some clean ups * Fix lint issue * Fix lint issue * Fix lint issue * Explicit action button search facets (#1457) * Change label * Add button * Add button * Full width search bar (#1426) * First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting * Fix layout * Add functionality to the button * Fix lint issue, finally?! * Fix lint issue, finally! * Fix tests * Click Search button after typing search query * Refactor full text search * Apply prettier * Convert onChange to reactive stream * Fix elastic search test * refactored fulltext-searchbar component and minor css changes for the search bar container * test fix for naming change of the clear button to reset button --------- Co-authored-by: junjiequan <[email protected]>
Ingvord
added a commit
that referenced
this pull request
Aug 21, 2024
* Full width search bar (#1426) * First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting * Separating full text search from shared search bar * Add search and clear buttons; some clean ups * Fix lint issue * Fix lint issue * Fix lint issue * Explicit action button search facets (#1457) * Change label * Add button * Add button * Full width search bar (#1426) * First steps * Beautify * Use shared search bar component * Remove search bar from facets * Some clean ups * Some clean ups * Some clean ups * Code formatting * Fix layout * Add functionality to the button * Fix lint issue, finally?! * Fix lint issue, finally! * Extract PID filter, WIP * Fix css; some cleanups * Further progress * Remove search icon * Add edit mode * Add/remove filter * Extract ClearableInputComponent * Add location-filter.component.ts * Add group-filter.component.ts * Add type-filter.component.ts * Add keyword-filter.component.ts * Add date-range-filter.component.ts * Add text-filter.component.ts * Show addable entities by default * Show default filters * Remove edit mode; some cleanups * Cleanup * Fix tests * build(deps-dev): bump the eslint group with 2 updates Bumps the eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 7.7.0 to 7.7.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.7.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 7.7.0 to 7.7.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.7.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps-dev): bump cypress from 13.7.3 to 13.8.0 Bumps [cypress](https://github.com/cypress-io/cypress) from 13.7.3 to 13.8.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v13.7.3...v13.8.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * feat: Updated logo configuration (#1459) * added configuration for site logos and updated default images * fixed linting, added documentation and named images correctly * Fix tests * Introduce dialog * Click Search button after typing search query * Refactor full text search * Apply prettier * Convert onChange to reactive stream * Post merge * Fix elastic search test * Implementing Filter Settings dialog concept * Implementing Filter Settings dialog concept * Resolve post merge issues * Prettify * Prettify * Fix undefined input * Fix tests compilation * Resolve TODO: improve readability * Fix tests * Clean up unused imports * Prettify scientific conditions * Prettify scientific conditions * Prettify scientific conditions * Resolve #1466 * Remove redundant behavior * fix tests * fix tests * Fix tests * Add tests * Progress: move filters into a dedicated module; store filters state in User state * Progress: move filters into a dedicated module; store filters state in User state * Fix eslint * fix tests * make sonar happy(ier) * Replace Filter by... with Filters and Conditions * Extract filter html templates and css into separate files * Fix tests * Fix tests * Do not call fixture.destroy manually * Fix tests * Remove inheritance as it makes Angular testing unhappy * Revert "Do not call fixture.destroy manually" This reverts commit fb201ff. * Add fixture.destroy * Replace static label with external function call * Remove trivial tests to avoid code duplications in case inheritance has to be removed * Fix eslint * Fix tests * Avoid @ViewChild * Try to fix test as per [SO](https://stackoverflow.com/a/66695890) * Try to fix test as per [SO](https://stackoverflow.com/a/66695890) * Revert "Remove trivial tests to avoid code duplications in case inheritance has to be removed" This reverts commit 04666e4. * Try to fix test as per [SO](https://stackoverflow.com/a/66695890) * Revert "Remove inheritance as it makes Angular testing unhappy" This reverts commit d75db60 * Revert "Remove inheritance as it makes Angular testing unhappy" This reverts commit d75db60 * Change Labels * Separate Filters and Conditions sections in the filter settings dialog * Remove text filter * Auto enable new condition * Allow condition editing in the filter settings dialog * Fix clear function * Fix tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Max Novelli <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1456