Swap 3290 add tab scientific json metadata #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoganandaness
requested review from
nitrosx,
martin-trajanovski and
Junjiequan
nitrosx
reviewed
Feb 19, 2024
Comment on lines
160
to
161
| isLoggedIn && | ||
| isInOwnerGroup, |
There was a problem hiding this comment.
This will restrict access to the json scientific metadata only to authenticated users which are also owners of the dataset
It should be fine for now, but we should also open a new issue to address authorization to this tab
nitrosx
approved these changes
Feb 19, 2024
|
probably blocked on #1419 |
…github.com/SciCatProject/frontend into SWAP-3290-add-tab-scientific-json-metadata
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new tab to the Individual Datasets page called as Json Scientific Metadata. This tab will contain the Json form of the Metadata especially only the scientific section ie.,
.scientificMetadataMotivation
To show the Scientific Metadata information as a JSON
Fixes:
Changes:
Added new Tab along with other tabs. This tab is configurable based on the configuration settings.
Tests included/Docs Updated?