fix: fetchCurrentUser does not validate token expiration time #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrosx
approved these changes
Feb 19, 2024
Junjiequan
deleted the
SWAP-3792-scicat-fe-refresh-page-without-login-shows-401-un
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user logs in, the loopbackAuth mechanism stores the authentication token in the browser's cookies. However, it fails to automatically remove this token once it has expired. Consequently, when the FetchCurrentUser action attempts to retrieve the user's profile from the backend using this expired JWT token, it results in a 401 Unauthorized error due to the token's invalidity.
Motivation
Background on use case, changes needed
Fixes:
Changes:
Tests included/Docs Updated?