Added flag to conditionally display unit list in metadata editing table. #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrosx
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
My comment is not blocking. So we can go ahead and merge if @bpedersen2 says that it is fine this way
bpedersen2
approved these changes
Jan 18, 2024
|
As for the E2E failures, see SciCatProject/scicat-backend-next#1013 |
bpedersen2
force-pushed
the
SWAP-3721-scicat-fe-in-the-scientificmetadata-table-edit-mo
branch
from
70d5afc to
a23fc4e
Compare
|
In the longer run we could consider switching the input to a combobox (edit+list) or use some autosuggest logic. But for now I would say: go ahead and merge |
…ata-table-edit-mo
…ata-table-edit-mo
…ata-table-edit-mo
Junjiequan
deleted the
SWAP-3721-scicat-fe-in-the-scientificmetadata-table-edit-mo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
metadataEditingUnitListDisabledflag to conditionally display available unit list in the metadata editing table.SciCatProject/scicat-backend-next#1014 needs to be merged for this change.
Motivation
The unit list is hard coded and shows only a limited unit list, which in some circumstances can give the user a false perception that they can only select predefined units from the list.
Changes:
Before
After
Tests included/Docs Updated?