-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proposal for #1135 #1136
Fix proposal for #1135 #1136
Conversation
Note that this patch requires to update the deployment's config |
@fpotier would you be able to expand the functionality in the following way:
Please let me know if it makes sense, or I should elaborate on it. |
@nitrosx Should this new configuration key Where should I write the associated documentation? |
@fpotier let's assume that it leaves in You can find the documentation in repo https://github.com/SciCatProject/documentation. |
@fpotier please let me know if my comment makes sense |
@nitrosx Yes it does, now it should work as you asked |
<ng-template #otherFacility> | ||
<img class="logo" src="../../../assets/images/site-logo.png" /> | ||
</ng-template> | ||
<img class="logo" src="../../../assets/images/header-logo.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking something as the following:
<ng-template [ngIf]="logoIcon === '' or logoIcon ==='default'" [ngIfElse="customLogo">
<img class="logo" src="../../../asstes/images/header-logo.png" />
</ng-template>
<ng-template #customLogo>
<img class="logo" src="../../../asstes/images/{{ logoIcon }}" />
</ng_template>
See #1135