Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gpiocontrol.py #465

Merged
merged 8 commits into from
Aug 17, 2020
Merged

Update gpiocontrol.py #465

merged 8 commits into from
Aug 17, 2020

Conversation

flothi
Copy link
Collaborator

@flothi flothi commented Jul 28, 2020

Fixing indentation-error reported on #458

Bastian Schroll and others added 4 commits April 28, 2020 13:01
@flothi flothi added the Bug label Jul 28, 2020
@flothi flothi requested a review from Schrolli91 July 28, 2020 21:36
@flothi flothi mentioned this pull request Jul 28, 2020
Closed
@flothi
Copy link
Collaborator Author

flothi commented Jul 29, 2020 •
edited
Loading

#466

@Schrolli91
Copy link
Owner

Schrolli91 commented Jul 30, 2020 •
edited
Loading

@flothi ist das (#466 ) genau der Fehler, den du hier behoben hast?
Btw: Changelog bitte noch ergänzen

@flothi
Fixing another indentation error
d75800e 
Fixing various errors and adding changelog
@flothi
Copy link
Collaborator Author

flothi commented Aug 1, 2020

@Schrolli91 War ein Folgefehler, jetzt siehts für mich soweit gut aus.

Schrolli91
Schrolli91 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Owner

@Schrolli91 Schrolli91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schrolli91 Schrolli91 mentioned this pull request Aug 3, 2020
Closed
@Schrolli91 Schrolli91 changed the base branch from master to develop August 3, 2020 12:24
@Schrolli91
Copy link
Owner

Hab gerade gesehen dass der PR gegen master gestellt war.
Hab das eben auf Dev geändert und musste dabei kurz nen Konflikt beheben.
@flothi schau nochmal kurz drüber obs so passt, dann würde ich mergen

@Schrolli91 Schrolli91 merged commit 0f95820 into develop Aug 17, 2020
@Schrolli91 Schrolli91 deleted the hotfix-gpio branch August 17, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schrolli91 Schrolli91 Schrolli91 approved these changes

Assignees
No one assigned
Labels
Bug Plugin Priorität Hoch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flothi @Schrolli91