Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring RegEx #416

Merged
merged 8 commits into from
Oct 23, 2019
Merged

Refactoring RegEx #416

merged 8 commits into from
Oct 23, 2019

Conversation

flothi
Copy link
Collaborator

@flothi flothi commented Oct 17, 2019

Changing RegEx to check entry; FMS containing chars inbetween had not been loaded, so the RegEx (l. 46) has been changed to correct it.

Also: removing semicolon in l 105

Refers to #409

Bastian Schroll and others added 5 commits October 13, 2019 17:56
HOTFIX pocsag decoder
7904fc3 
Fixes #413
@flothi
HOTFIX pocsag decoder
a994381 
HOTFIX pocsag decoder to solve #413 ; definition of var in both functions.
Merge pull request #414 from Schrolli91/hotfix_poc-decoder
18bde9d 
HOTFIX pocsag decoder
Update CHANGELOG.md
ca26f1d
@flothi
Refactoring RegEx
c631692 
Changing RegEx to check entry; FMS containing chars inbetween had not been loaded, so the RegEx (l. 46) has been changed to correct it.

Also: removing semicolon in l 105
@flothi flothi mentioned this pull request Oct 17, 2019
Closed
@Schrolli91 Schrolli91 changed the base branch from master to develop October 17, 2019 10:03
@flothi
Update descriptionList.py
dc00fbc 
Simplifying RegEx because of set IGNORECASE
@flothi
Copy link
Collaborator Author

flothi commented Oct 17, 2019

Habs angepasst

@Schrolli91
Copy link
Owner

Schrolli91 commented Oct 17, 2019 •
edited
Loading

hab mal ne FI vom develop gemacht - bitte noch den Changelog anpassen

Schrolli91
Schrolli91 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Owner

@Schrolli91 Schrolli91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fehlen nur noch Tests

@Schrolli91
Copy link
Owner

Ich geh jetzt einfach mal davon aus, das dass so passt - ansonsten wirds ja sicher einen Bug Report geben.
Die Änderung ist ja überschaubar ...

@Schrolli91 Schrolli91 merged commit a5b4a4a into develop Oct 23, 2019
@Schrolli91 Schrolli91 deleted the patch-csv branch October 23, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schrolli91 Schrolli91 Schrolli91 approved these changes

Assignees
No one assigned
Labels
BOSWatch Bug Review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flothi @Schrolli91