Feature xlsx #57
Merged
Feature xlsx #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +61,10 @@ def say(*arg): | |||
|
|
|||
| def isExtensionSupported(filename): | |||
| result = False | |||
| extensions = [".xml",".csv",".txt",".tsv",".html"] | |||
| if xlsxwriter_available: | |||
There was a problem hiding this comment.
I would have a default extensions array, and then optionally append '.xlsx' if xlsxwriter_available is True
|
Hi @Ximi1970 thanks for adding this feature! Please have a look at my review notes above. |
|
Hi @SchrodingersGat, I cleaned up the extension handling and also removed the "missing module" message. |
|
@Ximi1970 awesome, thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional XLSX output format support. Automatically detects XlsxWriter module.