Tolerate no output_file_name and/or variant_file_name_format
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fallbacks to the current default values, avoiding an exception. Should close issue SchrodingersGat#70
set-soft
added a commit
to INTI-CMNB/KiBoM
that referenced
this pull request
Jul 20, 2020
set-soft
added a commit
to INTI-CMNB/KiBoM
that referenced
this pull request
Jul 20, 2020
- Added warning if boolean options aren't 0,1,yes,no,true,false
- `as_link` and `digikey_link`: avoid writing "False" boolean, which
then is loaded as "False" string. Now using '' which is equivalent
to False. (bool('') -> False). Introduced by me on
SchrodingersGat#112 and SchrodingersGat#114.
- Put all SECTION_GENERAL options inside the already existing if.
- `backup` also made to default to '' instead of False for coherence.
- `hide_headers` and `hide_pcb_info` now support the same options as
other booleans. Also write them as '0', not 'False' for coherence
with all the other booleans.
- `board_variant` write as a string, not an array (bizarre
['default']" in created *bom.ini*)
- Add a checkStr method, to make it similar to checkInt and
checkOption. Making the general options much more compact in the
code.
- `output_file_name` and `variant_file_name_format` now use a more
general fallback mechanism (fallback option is documented only for
Python 3). Better than what I did in SchrodingersGat#121.
set-soft
added a commit
to INTI-CMNB/KiBoM
that referenced
this pull request
Jul 30, 2020
fallback is Python 3+
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fallbacks to the current default values, avoiding an exception.
Should close issue #70