Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#391] 동아리 정보 μž…λ ₯νŽ˜μ΄μ§€ κ΅¬ν˜„ #394

Merged
merged 7 commits into from
Aug 8, 2024
Merged

πŸ”€ :: [#391] 동아리 정보 μž…λ ₯νŽ˜μ΄μ§€ κ΅¬ν˜„ #394

merged 7 commits into from
Aug 8, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Aug 1, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

동아리 정보 μž…λ ₯ νŽ˜μ΄μ§€ 퍼블리싱과 κΈ°λŠ₯연결을 ν•¨κ»˜ μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.

Resolves: #391

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 동아리 정보 μž…λ ₯ νŽ˜μ΄μ§€λ₯Ό νΌλΈ”λ¦¬μ‹±ν–ˆμ–΄μš”.
  • 동아리 생성
  • 동아리 μˆ˜μ •
  • 동아리 μ‚­μ œ
    μœ„ κΈ°λŠ₯을 μΆ”κ°€ν–ˆμ–΄μš”.

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

학ꡐ 등둝 -> 등둝 μ™„λ£Œ νŽ˜μ΄μ§€ -> 학ꡐ λ“±λ‘νŽ˜μ΄μ§€λ‘œ μ΄λ™λ˜λ˜ νŽ˜μ΄μ§€λ₯Ό λ°”λ‘œ 학ꡐ λͺ©λ‘ νŽ˜μ΄μ§€λ‘œ μ΄λ™ν•˜λ„λ‘ λ³€κ²½ν–ˆμ–΄μš”.
ModifyClubRequestDTO와 CreatedClubRequestDTO둜 λΆ„λ¦¬λ˜μ–΄μžˆλ˜ νŒŒμΌμ„ InputClubRequestDTO둜 λ³‘ν•©ν–ˆμ–΄μš”.

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@uuuunseo uuuunseo added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 ✨ Feature μ‹ κ·œ κΈ°λŠ₯ labels Aug 1, 2024
@uuuunseo uuuunseo self-assigned this Aug 1, 2024
@uuuunseo uuuunseo changed the title 391 input club feature πŸ”€ :: [#391] 동아리 정보 μž…λ ₯νŽ˜μ΄μ§€ κ΅¬ν˜„ Aug 1, 2024
Base automatically changed from 391-input-school-api-connect to master August 8, 2024 04:30
@uuuunseo uuuunseo merged commit 6f958c4 into master Aug 8, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 391-input-club-feature branch August 8, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GangMinSu GangMinSu GangMinSu approved these changes

Assignees

@uuuunseo uuuunseo

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ✨ Feature μ‹ κ·œ κΈ°λŠ₯ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

학ꡐ 상세, 등둝, λ™μ•„λ¦¬λ””μžμΈ λ³€κ²½ 적용
2 participants
@uuuunseo @GangMinSu