Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#386] λŒ€ν•™ ν•™κ³Ό 리슀트 쑰회 κΈ°λŠ₯ μΆ”κ°€ #388

Merged
merged 1 commit into from
Jul 27, 2024
Merged

πŸ”€ :: [#386] λŒ€ν•™ ν•™κ³Ό 리슀트 쑰회 κΈ°λŠ₯ μΆ”κ°€ #388

merged 1 commit into from
Jul 27, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jul 25, 2024 •
edited
Loading

Resolves: #386

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • λŒ€ν•™ λͺ©λ‘νŽ˜μ΄μ§€μ— λŒ€ν•™ ν•™κ³Ό 리슀트 쑰회 κΈ°λŠ₯을 μΆ”κ°€ν–ˆμ–΄μš”.

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@uuuunseo uuuunseo added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ✨ Feature μ‹ κ·œ κΈ°λŠ₯ labels Jul 25, 2024
@uuuunseo uuuunseo self-assigned this Jul 25, 2024
Base automatically changed from 386-university-list-page-publishing to master July 27, 2024 15:21
@uuuunseo uuuunseo merged commit e74fe6e into master Jul 27, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 386-university-list-api-connect branch July 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likegitman likegitman likegitman approved these changes

Assignees

@uuuunseo uuuunseo

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ✨ Feature μ‹ κ·œ κΈ°λŠ₯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λŒ€ν•™ λͺ©λ‘ νŽ˜μ΄μ§€
2 participants
@uuuunseo @likegitman