Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#372] government ๋„๋ฉ”์ธ ์„ธํŒ… #373

Merged
merged 12 commits into from
Jul 20, 2024
Merged

๐Ÿ”€ :: [#372] government ๋„๋ฉ”์ธ ์„ธํŒ… #373

merged 12 commits into from
Jul 20, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jul 18, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์œ ๊ด€๊ธฐ๊ด€ CRUD๊ธฐ๋Šฅ์ด ์ถ”๊ฐ€๋˜์–ด API ์„ธํŒ…์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค...!

Resolves: #372

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ์œ ๊ด€๊ธฐ๊ด€ ๋ฆฌ์ŠคํŠธ ์กฐํšŒ
  • ์œ ๊ด€๊ธฐ๊ด€ ์ƒ์„ฑ
  • ์œ ๊ด€๊ธฐ๊ด€ ์‚ญ์ œ
    ์œ„์˜ API๋“ค์„ ์„ธํŒ…ํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

@uuuunseo uuuunseo added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โš™ Setting ํ™˜๊ฒฝ ์„ธํŒ… โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Jul 18, 2024
@uuuunseo uuuunseo self-assigned this Jul 18, 2024
Base automatically changed from 370-university-domain-setting to master July 19, 2024 12:17
@uuuunseo uuuunseo merged commit 23fffc3 into master Jul 20, 2024
2 checks passed
@uuuunseo uuuunseo linked an issue Jul 20, 2024 that may be closed by this pull request
government ๋„๋ฉ”์ธ ์„ธํŒ… #372
Closed
@uuuunseo uuuunseo deleted the 372-government-domain-setting branch July 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likegitman likegitman likegitman approved these changes

@ani2689 ani2689 ani2689 approved these changes

Assignees

@uuuunseo uuuunseo

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ โš™ Setting ํ™˜๊ฒฝ ์„ธํŒ…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

government ๋„๋ฉ”์ธ ์„ธํŒ…
3 participants
@uuuunseo @likegitman @ani2689