Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#370] university๋„๋ฉ”์ธ ์„ธํŒ… #371

Merged
merged 13 commits into from
Jul 19, 2024
Merged

๐Ÿ”€ :: [#370] university๋„๋ฉ”์ธ ์„ธํŒ… #371

merged 13 commits into from
Jul 19, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jul 18, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

UniversityDomain์ด ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”.

Resolves: #370

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋Œ€ํ•™ ํ•™๊ณผ ๋ฆฌ์ŠคํŠธ ์กฐํšŒ
  • ๋Œ€ํ•™ ์ƒ์„ฑ
  • ๋Œ€ํ•™ ์ˆ˜์ •
  • ๋Œ€ํ•™ ์‚ญ์ œ
  • ํ•™๊ณผ ์ƒ์„ฑ
  • ํ•™๊ณผ ์ˆ˜์ •
    ์œ„์˜ API๋ฅผ ์„ธํŒ…ํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

@uuuunseo uuuunseo added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โš™ Setting ํ™˜๊ฒฝ ์„ธํŒ… โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Jul 18, 2024
@uuuunseo uuuunseo self-assigned this Jul 18, 2024
@uuuunseo uuuunseo linked an issue Jul 18, 2024 that may be closed by this pull request
University ๋„๋ฉ”์ธ ์„ธํŒ… #370
Closed
@uuuunseo uuuunseo changed the base branch from master to 368-company-domain-setting July 18, 2024 04:44
Base automatically changed from 368-company-domain-setting to master July 18, 2024 23:53
@uuuunseo uuuunseo merged commit b0c46dd into master Jul 19, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 370-university-domain-setting branch July 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ani2689 ani2689 ani2689 approved these changes

Assignees

@uuuunseo uuuunseo

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ โš™ Setting ํ™˜๊ฒฝ ์„ธํŒ…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

University ๋„๋ฉ”์ธ ์„ธํŒ…
2 participants
@uuuunseo @ani2689