Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#354] κ°•μ˜ μ‚­μ œ κΈ°λŠ₯ μΆ”κ°€ #355

Merged
merged 5 commits into from
Jul 3, 2024
Merged

πŸ”€ :: [#354] κ°•μ˜ μ‚­μ œ κΈ°λŠ₯ μΆ”κ°€ #355

merged 5 commits into from
Jul 3, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jul 3, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

κ°•μ˜ μ‚­μ œ κΈ°λŠ₯이 μΆ”κ°€λ˜κ³  λ””μžμΈμ΄ λ³€κ²½λ˜μ–΄μ„œ μ μš©ν–ˆμ–΄μš”.
Resolves: #354

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • κ°•μ˜ μ‚­μ œ κΈ°λŠ₯을 μΆ”κ°€ν–ˆμ–΄μš”.

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

  • μœ κ΄€κΈ°κ΄€ νšŒμ›κ°€μž… ν…ŒμŠ€νŠΈ 쀑 νšŒμ›κ°€μž…μ΄ μ•ˆλ˜λŠ” 였λ₯˜κ°€ μžˆμ–΄μ„œ ν™•μΈν•΄λ³΄λ‹ˆ 동아리 μž…λ ₯ ν•„λ“œκ°€ λΉ μ Έμžˆμ–΄μ„œ μΆ”κ°€ν•΄μ„œ μœ κ΄€κΈ°κ΄€ νšŒμ›κ°€μž…μ΄ κ°€λŠ₯ν•˜κ²Œ λ³€κ²½ν–ˆμ–΄μš”.
  • 동아리 상세 μ‘°νšŒκ°€ λ˜μ§€ μ•Šμ•„μ„œ ν™•μΈν•΄λ³΄λ‹ˆ highSchoolName -> schoolName으둜 ν•„λ“œκ°€ λ³€κ²½λ˜μ–΄μ„œ 데이터λ₯Ό κ°€μ Έμ˜¬ 수 μ—†λŠ” μ΄μŠˆμ—¬μ„œ fixν–ˆμ–΄μš”!!

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@uuuunseo uuuunseo added 1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 ✨ Feature μ‹ κ·œ κΈ°λŠ₯ labels Jul 3, 2024
@uuuunseo uuuunseo self-assigned this Jul 3, 2024
@uuuunseo uuuunseo linked an issue Jul 3, 2024 that may be closed by this pull request
κ°•μ˜ μ‚­μ œ κΈ°λŠ₯ μΆ”κ°€ #354
Closed
TaerangLee
TaerangLee approved these changes Jul 3, 2024
View reviewed changes
Copy link

@TaerangLee TaerangLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! 🫒

@uuuunseo uuuunseo merged commit 0c4d74f into master Jul 3, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 354-add-lecture-delete branch July 3, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaerangLee TaerangLee TaerangLee approved these changes

Assignees

@uuuunseo uuuunseo

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 ✨ Feature μ‹ κ·œ κΈ°λŠ₯ ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

κ°•μ˜ μ‚­μ œ κΈ°λŠ₯ μΆ”κ°€
2 participants
@uuuunseo @TaerangLee