Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: [#350] URL ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ๊ธฐ๋Šฅ ์ถ”๊ฐ€ #351

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jun 18, 2024 โ€ข

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • ๊ฒŒ์‹œ๊ธ€, ๊ณต์ง€์‚ฌํ•ญ ์„ธ๋ถ€์„ค์ • ํŽ˜์ด์ง€์—์„œ ๋งํฌ๋ฅผ ์ถ”๊ฐ€ํ•˜๋Š” ๋ถ€๋ถ„์—์„œ URL ์œ ํšจ์„ฑ์„ ๊ฒ€์‚ฌํ•˜๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™๋‹ค๋Š” QA ํ”ผ๋“œ๋ฐฑ
  • ๊ฒŒ์‹œ๊ธ€, ๊ณต์ง€์‚ฌํ•ญ ์ƒ์„ธ ํŽ˜์ด์ง€์—์„œ ๊ด€๋ จ ๋งํฌ๋ณด๊ธฐ ๋ถ€๋ถ„์— ์ค„ ์ •๋ ฌ์ด center๋กœ ๋˜์–ด์žˆ๋Š” ๋ถ€๋ถ„
  • ๋ฌธ์˜ ์‚ฌํ•ญ์ด ๋ชฉ๋ก ํŽ˜์ด์ง€์—์„œ ๋ฌธ์˜์‚ฌํ•ญ์ด ์—†์„ ๋•Œ NoInfoView๊ฐ€ ์œ„๋กœ ์˜ฌ๋ผ๊ฐ€ ์žˆ๋Š” ๋ฌธ์ œ
  • ๊ฒŒ์‹œ๊ธ€, ๊ณต์ง€์‚ฌํ•ญ ์ƒ์„ธํŽ˜์ด์ง€์— ๊ฒŒ์‹œ๋‚ ์งœ, ๊ฒŒ์‹œ์ž ์ถ”๊ฐ€ ๋””์ž์ธ ๋ฐ˜์˜
    QA์ง„ํ–‰ ์ค‘์— ๋‚˜์˜จ ํ”ผ๋“œ๋ฐฑ๋“ค์„ ๋ฐ˜์˜ํ•ด์•ผํ•ด์š”.

Resolves: #350

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๊ฒŒ์‹œ๊ธ€, ๊ณต์ง€์‚ฌํ•ญ ์„ธ๋ถ€์„ค์ • ํŽ˜์ด์ง€ ๋งํฌ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๊ฒŒ์‹œ๊ธ€, ๊ณต์ง€์‚ฌํ•ญ ์ƒ์„ธ ํŽ˜์ด์ง€ ๊ด€๋ จ ๋งํฌ๋ณด๊ธฐ ์ค„ ์ •๋ ฌ ๋ณ€๊ฒฝ
  • ๋ฌธ์˜์‚ฌํ•ญ ๋ชฉ๋ก ํŽ˜์ด์ง€์—์„œ ๋ฌธ์˜์‚ฌํ•ญ์˜ ์—†์„ ๋•Œ NoInfoView ์œ„์น˜ ๋ณ€๊ฒฝ
  • ๊ฒŒ์‹œ๊ธ€, ๊ณต์ง€์‚ฌํ•ญ ์ƒ์„ธ ํŽ˜์ด์ง€ ๊ฒŒ์‹œ๋‚ ์งœ, ๊ฒŒ์‹œ์ž ๋””์ž์ธ๋ณ€๊ฒฝ ๋ฐ˜์˜

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

@uuuunseo uuuunseo added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ ๐Ÿž Bug ๋ฒ„๊ทธ ๋ฐœ์ƒ labels Jun 18, 2024
@uuuunseo uuuunseo requested a review from Xixn2 June 18, 2024 04:57
@uuuunseo uuuunseo self-assigned this Jun 18, 2024
@uuuunseo uuuunseo linked an issue Jun 18, 2024 that may be closed by this pull request
@uuuunseo uuuunseo merged commit 5be0890 into master Jun 18, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 350-add-url-validation branch June 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ ๐Ÿž Bug ๋ฒ„๊ทธ ๋ฐœ์ƒ โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜
3 participants