Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#343] FAQ๋ฆฌ์ŠคํŠธ ์ˆ˜์ •, default localization ์ˆ˜์ • #344

Merged
merged 1 commit into from
Jun 5, 2024
Merged

๐Ÿ”€ :: [#343] FAQ๋ฆฌ์ŠคํŠธ ์ˆ˜์ •, default localization ์ˆ˜์ • #344

merged 1 commit into from
Jun 5, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jun 5, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์•ฑ ์Šคํ† ์–ด ์‹ฌ์‚ฌ ์ค‘ ๊ฐ€์ด๋“œ๋ผ์ธ๊ณผ ๋งž์ง€ ์•Š๋‹ค๋Š” ์ด์œ ๋กœ ๋ฆฌ์ ์„ ๋‹นํ–ˆ์–ด์š”.

Resolves: #343

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • FAQ๋ฆฌ์ŠคํŠธ ๋ถ€๋ถ„์„ ๊ฐ€์šด๋ฐ ์ •๋ ฌ๋กœ ๋˜์–ด์žˆ๋˜ ๋ถ€๋ถ„์„ ์™ผ์ชฝ ์ •๋ ฌ๋กœ ์ˆ˜์ •ํ–ˆ์–ด์š”.
  • default localization์„ ko_KR๋กœ ์ˆ˜์ •ํ–ˆ์–ด์š”.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

@uuuunseo uuuunseo added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ ๐Ÿž Bug ๋ฒ„๊ทธ ๋ฐœ์ƒ labels Jun 5, 2024
@uuuunseo uuuunseo requested a review from shwaaaa June 5, 2024 07:04
@uuuunseo uuuunseo self-assigned this Jun 5, 2024
@uuuunseo uuuunseo linked an issue Jun 5, 2024 that may be closed by this pull request
FAQ, Info ์ˆ˜์ • #343
Closed
@uuuunseo uuuunseo merged commit 09253b1 into master Jun 5, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 343-modify-faq-info branch June 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwaaaa shwaaaa shwaaaa approved these changes

Assignees

@uuuunseo uuuunseo

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ ๐Ÿž Bug ๋ฒ„๊ทธ ๋ฐœ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ, Info ์ˆ˜์ •
2 participants
@uuuunseo @shwaaaa