Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#104] ํ•™์ƒํ™œ๋™ ์ƒ์„ธ ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ #118

Merged
merged 29 commits into from
Feb 6, 2024
Merged

๐Ÿ”€ :: [#104] ํ•™์ƒํ™œ๋™ ์ƒ์„ธ ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ #118

merged 29 commits into from
Feb 6, 2024

Conversation

uuuunseo
Copy link
Contributor

@uuuunseo uuuunseo commented Jan 3, 2024

๐Ÿ’ก ๊ฐœ์š”

ํ•™์ƒํ™œ๋™ ์ƒ์„ธ ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

image

๐ŸŽธ ๊ธฐํƒ€

์„œ๋ฒ„์™€์˜ ์—ฐ๊ฒฐ ๋ฐ Navigate๋ฅผ ์•ˆ ํ•ด์„œ ๋ถ€์‹คํ•ด ๋ณด์ผ ์ˆ˜๋„ ์žˆ์ง€๋งŒ ํ™•์ธ ํ•ด์ฃผ์„ธ์š”!!

@uuuunseo uuuunseo added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Jan 3, 2024
@uuuunseo uuuunseo self-assigned this Jan 3, 2024
@uuuunseo uuuunseo linked an issue Jan 3, 2024 that may be closed by this pull request
ํ•™์ƒ ํ™œ๋™ ์ƒ์„ธ ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ #104
Closed
shwaaaa
shwaaaa approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@shwaaaa shwaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์–ด์š”!

kimkyumbi
kimkyumbi approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@kimkyumbi kimkyumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹น ใ…Ž

uuuunseo and others added 12 commits January 11, 2024 11:24
@uuuunseo
โ™ป๏ธ :: [#104] Domain / uuid() -> string์œผ๋กœ ๋ณ€๊ฒฝ
3ec2f79
@uuuunseo
๐Ÿ”ฅ :: [#104] ActivityAPI / query String ๋ถ€๋ถ„ ์‚ญ์ œ
d52639a
@uuuunseo
โ™ป๏ธ :: [#104] ActivityFeature / id ๋ถ€๋ถ„ String์œผ๋กœ ๋ณ€๊ฒฝ
eccf86d
@uuuunseo
โœจ :: [#104] AppComponent / activityDetailFactory ์ถ”๊ฐ€
44d6427
@uuuunseo
โ™ป๏ธ :: [#104] ActivityDomain / userId -> activityId๋กœ ๋ณ€๊ฒฝ
d773f83
@uuuunseo
โ™ป๏ธ :: [#104] ActivityDetailFeature / userId -> activityId๋กœ ๋ณ€๊ฒฝ
964651b
@uuuunseo
โ™ป๏ธ :: [#104] ActivityAPI / userId -> activityId๋กœ ์ˆ˜์ •
b931e59
@uuuunseo
โœจ :: [#104] Testing / QueryActivityDetailUseCaseStub ์ถ”๊ฐ€
e322f98
@uuuunseo
โœจ :: [#104] ActivityDetailView / PopupButton Action ์ถ”๊ฐ€
f1a2216
@uuuunseo
โœจ :: [#104] ActivityListView / ActivityList -> ActivityDetail ํ™”๋ฉด ์ „ํ™˜ ๋กœโ€ฆ
5135ade 
โ€ฆ์ง ์ถ”๊ฐ€
@uuuunseo
โ™ป๏ธ :: SwiftFormat
8bb22f3
@uuuunseo @baekteun
Update App/Sources/Feature/ActivityDetailFeature/Sources/ActivityDetaโ€ฆ
b3d48f6 
โ€ฆilView.swift

Co-authored-by: baegteun <[email protected]>
@baekteun
Copy link
Contributor

@uuuunseo ์ปจํ”Œ๋ฆญํŠธ ๋‚ฌ์–ด์š” pull ๋ฐ›์œผ์…”์•ผํ• ๊ฑฐ๊ฐ™์•„์šฉ

@uuuunseo uuuunseo merged commit 85b9174 into master Feb 6, 2024
2 checks passed
@uuuunseo uuuunseo deleted the 104-student-activity-detail-page-publishing branch February 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@shwaaaa shwaaaa shwaaaa approved these changes

@kimkyumbi kimkyumbi kimkyumbi approved these changes

Assignees

@uuuunseo uuuunseo

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ํ•™์ƒ ํ™œ๋™ ์ƒ์„ธ ํŽ˜์ด์ง€ ํผ๋ธ”๋ฆฌ์‹ฑ
4 participants
@uuuunseo @baekteun @shwaaaa @kimkyumbi