Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StudentSignUp 리팩토링 #79

Closed
shwaaaa opened this issue Nov 15, 2023 · 0 comments · Fixed by #117
Closed

StudentSignUp 리팩토링 #79

shwaaaa opened this issue Nov 15, 2023 · 0 comments · Fixed by #117
Assignees
@shwaaaa
Labels
2️⃣ Priority: Medium 우선순위 - 중 ♻️ Refactor 코드 리팩토링

Comments

@shwaaaa
Copy link
Contributor

shwaaaa commented Nov 15, 2023 •
edited
Loading

Describe

StudentSignUp를 리팩토링합니다

Additional

No response
@shwaaaa shwaaaa added 2️⃣ Priority: Medium 우선순위 - 중 ♻️ Refactor 코드 리팩토링 labels Nov 15, 2023
@shwaaaa shwaaaa self-assigned this Nov 15, 2023
@shwaaaa shwaaaa changed the title StudentSignUpView 리팩토링 StudentSignUp 리팩토링 Jan 2, 2024
shwaaaa added a commit that referenced this issue Jan 2, 2024
@shwaaaa
♻️ :: [#79] 학생 회원가입 로직에 공통 회원가입 로직 추가
118ce29
@shwaaaa shwaaaa linked a pull request Jan 2, 2024 that will close this issue
🔀 :: [#79] 학생 회원가입 로직에 공통 회원가입 로직 추가 #117
Merged
shwaaaa added a commit that referenced this issue Jan 4, 2024
@shwaaaa
🚚 :: [#79] isSchool -> isPresentedSchoolSheet
ba5c612
shwaaaa added a commit that referenced this issue Jan 4, 2024
@shwaaaa
♻️ :: [#79] validation으로 분리
2ef59e2
shwaaaa added a commit that referenced this issue Jan 4, 2024
@shwaaaa
🔥 :: [#79] parseStudentID 삭제
17e2aca
shwaaaa added a commit that referenced this issue Jan 4, 2024
@shwaaaa
🔥 :: [#79] convertSecondsToTime 삭제
68dfff7
shwaaaa added a commit that referenced this issue Jan 10, 2024
@shwaaaa
Merge pull request #117 from GSM-MSG/79-studentsignup-refactoring
aa997f2 
🔀 :: [#79] 학생 회원가입 로직에 공통 회원가입 로직 추가
shwaaaa added a commit that referenced this issue Jan 12, 2024
@shwaaaa
♻️ :: [#79] selectedClud 옵셔널로 변경
6ddf279
shwaaaa added a commit that referenced this issue Jan 12, 2024
@shwaaaa
♻️ :: [#79] parseStudentID 추가
81c22aa
shwaaaa added a commit that referenced this issue Jan 13, 2024
@shwaaaa
Merge pull request #119 from GSM-MSG/79-validation-refactoring
53cb9ff 
🔀 :: [#79] 학생회원가입 검증 로직 리팩토링
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shwaaaa shwaaaa

Labels
2️⃣ Priority: Medium 우선순위 - 중 ♻️ Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
1 participant
@shwaaaa