Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus CI schema #488

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Cirrus CI schema #488

merged 1 commit into from
Jul 14, 2018

Conversation

fkorotkov
Copy link
Contributor

JSON schema for Cirrus CI configuration files.

This schema is generate from our internal parser of .cirrus.yml files with help of https://github.com/everit-org/json-schema library.

@fkorotkov
Copy link
Contributor Author

I don't quite understand why the tests are failing with: Cannot read property 'replace' of undefined

@fkorotkov
Copy link
Contributor Author

Can it be because gulp-tv4 does validation agains draft 4?

@madskristensen
Copy link
Contributor

Most editors only supports draft v4. If possible, keep schemas as v4

@fkorotkov
Copy link
Contributor Author

@madskristensen I believe draft v4 doesn't have patternProperty feature that is needed for Cirrus CI's configuration file. 😢 There can be multiple (.*)task properties like build_task and test_task.

@Clemens-U
Copy link
Contributor

Draft 4 does include the "patternProperties" keyword https://tools.ietf.org/html/draft-fge-json-schema-validation-00

JSON schema for Cirrus CI configuration files.
@fkorotkov
Copy link
Contributor Author

@Clemens-U seems I missed it! Update the schema and added a test!

/cc @madskristensen

@madskristensen madskristensen merged commit 8d6c8c7 into SchemaStore:master Jul 14, 2018
@fkorotkov fkorotkov deleted the fedor/cirrus-ci branch July 16, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants