Address first batch of credo issues found in #53 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 24, 2018 02:04
… of reraise, losing stack trace.
…rn of credo warning for inspect since it's a mix task and that's its job.
…andle_captured_input), by removing debug spam inspect. If we still need it, should be properly instrtumented via Logger anyways.
…binary), by ignoring code dupe warning. This is caused by same code structure in body and function head, but there's no more convenient way to factor this. Suggest warning credo folks.
…Transform.Translate) and lib/scenic/primitive/transform/pin.ex:7 #(Scenic.Primitive.Trnasform.Pin), by delegating pin to transform. Identical code, delegation cleanest fix and reduces chance for them to get out of sync.
crertel
changed the title
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 63.33% 63.38% +0.04%
==========================================
Files 80 80
Lines 1961 1958 -3
==========================================
- Hits 1242 1241 -1
+ Misses 719 717 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the first handful of issues from credo--namely, some warnings and design complaints (credo's terminology, not mine).
This was done mostly by turning off some of the more obnoxious errors, while occasionally laying hands on code to either delegate (to remove duplication), remove debug spam, or tweak exception handling.
All changes were run through the test suite and came back green, but we don't have 100% coverage so that's of questionable worth. I tried to stick with changes that by inspection should be correct.
Motivation and Context
This fixes partially fixes #53 , since Credo out-of-the-box is super persnickety. If we like the work I did here, I'm happy to finish clearing out the credo complaints (currently ~ 206) so we can start from a cleanish slate going forward.
Types of changes
not work as expected)
but make things better)
Elaboration on the breaking change: I removed some console spam in the viewport input code. It's a breaking change because that output won't be there if you're looking for it--shouldn't harm anything else though.
Checklist