Skip to content

Add next and latest to return value #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

PolonaM
Copy link
Collaborator

@PolonaM PolonaM commented Mar 30, 2023

To be able to choose next (the lowest number) or latest (the highest number) update from the list of available updates, next and latest are added to return value.

@PolonaM PolonaM marked this pull request as draft March 30, 2023 13:00
@PolonaM PolonaM force-pushed the version_update_info_next_and_newest branch from cb4bf3d to 05b837c Compare March 30, 2023 21:01
@PolonaM PolonaM marked this pull request as ready for review March 30, 2023 21:05
@PolonaM PolonaM requested a review from justinc1 March 30, 2023 21:05
@PolonaM PolonaM force-pushed the version_update_info_next_and_newest branch from 2fcbac7 to e93c36a Compare March 31, 2023 08:03
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful to be able to list all possible version updates.

description: Unix timestamp when the update was released
type: int
sample: 0
record:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be records list iff you accept the change

@PolonaM PolonaM force-pushed the version_update_info_next_and_newest branch from c7a89aa to 63f1868 Compare April 3, 2023 10:58
@PolonaM PolonaM changed the title Add option select next or latest to version_update_info Add next and latest to return value Apr 3, 2023
@PolonaM PolonaM requested a review from justinc1 April 3, 2023 11:23
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added trivial change to "Lowest update is "{{ result.next.uuid | default('') }}" to make sure example works also if no update is available.
I will squash merge the PR.

@justinc1 justinc1 merged commit 330dab2 into main Apr 3, 2023
@justinc1 justinc1 deleted the version_update_info_next_and_newest branch April 3, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants