M3-US4 - Disk from snapshot to VM #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anazobec
commented
Mar 13, 2023
justinc1
requested changes
Mar 14, 2023
justinc1
reviewed
Mar 20, 2023
justinc1
requested changes
Mar 21, 2023
There was a problem hiding this comment.
We will make test infra (the 2 VMs and their snapshots) more complex later.
How to refactor filter_snapshots_by_params - if code works correctly, we can refactor it later. Nice code can wait.
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4477382452/jobs/7868844884 - test failed, need to be fixed.
File examples/attach_snapshot_disk_to_vm.yml - maybe we keep it in separate branch, because it has some comments inside. We cannot commit it (yet).
tests/integration/targets/vm_snapshot/tasks/01_vm_snapshot_info.yml
Outdated
Show resolved
Hide resolved
…d_classes for modules needs.
…ation tests for vm_snapshot_info.
anazobec
force-pushed
the
disk-from-snapshot-to-vm
branch
from
553a193 to
f83a706
Compare
justinc1
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vm_snapshot modules:
module_utils/vm_snapshotmodules/vm_snapshot_infoand integration tests for this one