Skip to content

M3 - Virtual disk - US02 - US03 - Create / Delete / List #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Mar 24, 2023
Merged

M3 - Virtual disk - US02 - US03 - Create / Delete / List #153

merged 38 commits into from
Mar 24, 2023

Conversation

domendobnikar
Copy link
Collaborator

@domendobnikar domendobnikar commented Mar 6, 2023 •
edited
Loading

As a user I want to be able to upload foreign virtual disks to the cluster from local file (list formats allowed - qcow2, vmdk, vhd):

Important: all conversion will be done by API

As a user I want to be able to list and delete uploaded virtual disks on cluster 

  • Create
  • List
  • Delete
  • Add document fragment

Attach will be done in a separate PR.

@domendobnikar domendobnikar marked this pull request as draft March 6, 2023 15:08
@domendobnikar domendobnikar changed the title Virtual disk - Create / Delete M3 - Virtual disk - Create / Delete Mar 6, 2023
@domendobnikar domendobnikar self-assigned this Mar 15, 2023
@domendobnikar domendobnikar changed the title M3 - Virtual disk - Create / Delete M3 - Virtual disk - Create / Delete / List Mar 15, 2023
@domendobnikar domendobnikar marked this pull request as ready for review March 16, 2023 09:23
@domendobnikar domendobnikar requested a review from justinc1 March 16, 2023 09:24
@domendobnikar domendobnikar changed the title M3 - Virtual disk - Create / Delete / List M3 - Virtual disk - US02 - US03 - Create / Delete / List Mar 16, 2023
@justinc1
Copy link
Collaborator

https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4466336327/ - jobs that failed here are not related to this PR (I believe). CI passes.

@domendobnikar domendobnikar requested a review from justinc1 March 21, 2023 11:02
justinc1
justinc1 requested changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid catching arbitrary exception

@domendobnikar domendobnikar requested a review from justinc1 March 23, 2023 15:28
@domendobnikar
Copy link
Collaborator Author

Integration tests:
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4502644952

justinc1
justinc1 requested changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use specific exception, not the generic ValueError. The palce where we erally decide that thia needs to be ignored - it is a few calls away, and ValueError could be triggered by other code, not just this json.loads.

@domendobnikar domendobnikar requested a review from justinc1 March 24, 2023 08:44
justinc1
justinc1 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. I will run integ test manually.

@justinc1 justinc1 merged commit 1530a27 into main Mar 24, 2023
@justinc1 justinc1 deleted the M3-2-Upload-VD branch March 24, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinc1 justinc1 justinc1 approved these changes

Assignees

@domendobnikar domendobnikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domendobnikar @justinc1