US1b - Add role for updating single-node systems. #136

anazobec · 2023-02-27T09:00:54Z

Added a role for updating single-node systems, required for US1b.

Example usage:

---
- name: Update HC3 single-node system
  include_role:
    name: scale_computing.hypercore.version_update_single_node
  vars:
    scale_computing_hypercore_desired_version: 9.1.23.210897

roles/version_update_single_node/tasks/main.yml

roles/version_update_single_node/tasks/update.yml

justinc1

I think I only need a few comment, as I do not understand a few things.

roles/version_update_single_node/tasks/main.yml

roles/version_update_single_node/tasks/update_status_check.yml

tests/integration/targets/role_version_update_single_node/tasks/01_update.yml

roles/version_update_single_node/tasks/main.yml

examples/version_update_single_node.yml

Signed-off-by: Justin Cinkelj <[email protected]>

Task "Check if desired update is available - end host if Not available" will also end play if there is no update available. Signed-off-by: Justin Cinkelj <[email protected]>

Maybe playbook author has some block with rescue/always section, and such code should be run if update fails. Signed-off-by: Justin Cinkelj <[email protected]>

…rsion We should not fail in such case. Signed-off-by: Justin Cinkelj <[email protected]>

anazobec self-assigned this Feb 27, 2023

anazobec requested a review from justinc1 February 27, 2023 09:04

ddemlow reviewed Feb 27, 2023

View reviewed changes

roles/version_update_single_node/tasks/main.yml Outdated Show resolved Hide resolved

justinc1 reviewed Feb 27, 2023

View reviewed changes

justinc1 reviewed Feb 28, 2023

View reviewed changes

roles/version_update_single_node/tasks/update.yml Outdated Show resolved Hide resolved

anazobec added 15 commits March 6, 2023 09:37

US1b - Add role for updating single-node systems.

4e6da1d

Update role.

08fdc45

Fix some of the requests.

ae79e0c

Update role, add integration tests.

684d501

Fix for sanity.

9d0cda0

Update integration tests.

57a6562

Update task in role.

b29fdd0

Prepare for using the version_update module.

e5db0c7

Temporarily comment out Update task in role.

481ef59

Fix for sanity, minor changes to role.

f60ab59

Test how ansible include_tasks work.

b235c60

Update role.

5545e36

Fix for sanity.

f322c8d

Fix for sanity again.

405de16

Test commit.

3390c64

anazobec force-pushed the US1b_single_node_systems branch from ec6de24 to 3390c64 Compare March 6, 2023 08:43

anazobec added 4 commits March 6, 2023 09:46

Remove blank new line.

5daaaa0

Add argument_specs for role.

9ac766d

Update role, role integration tests, fix role argument specs.

25d6068

Fix argument specs.

b7e2bfb

justinc1 approved these changes Mar 6, 2023

View reviewed changes

anazobec added 2 commits March 6, 2023 13:32

Update role as per requests.

73b8574

Add example for using this role.

eb4c4af

justinc1 approved these changes Mar 7, 2023

View reviewed changes

roles/version_update_single_node/tasks/main.yml Outdated Show resolved Hide resolved

examples/version_update_single_node.yml Show resolved Hide resolved

Run example in check_mode

b35ecda

Signed-off-by: Justin Cinkelj <[email protected]>

justinc1 added 3 commits March 7, 2023 07:49

Remove redundunt check

bd305bc

Task "Check if desired update is available - end host if Not available" will also end play if there is no update available. Signed-off-by: Justin Cinkelj <[email protected]>

Replace end_host with fail

b278d29

Maybe playbook author has some block with rescue/always section, and such code should be run if update fails. Signed-off-by: Justin Cinkelj <[email protected]>

Make role idempotent - do nothing if cluster is already on correct ve…

80dda4d

…rsion We should not fail in such case. Signed-off-by: Justin Cinkelj <[email protected]>

justinc1 merged commit 378c94f into main Mar 7, 2023

justinc1 deleted the US1b_single_node_systems branch March 7, 2023 07:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

US1b - Add role for updating single-node systems. #136

US1b - Add role for updating single-node systems. #136

anazobec commented Feb 27, 2023 •

edited

Loading

justinc1 left a comment

US1b - Add role for updating single-node systems. #136

US1b - Add role for updating single-node systems. #136

Conversation

anazobec commented Feb 27, 2023 • edited Loading

Example usage:

justinc1 left a comment

Choose a reason for hiding this comment

anazobec commented Feb 27, 2023 •

edited

Loading