Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.8.7.0 release #338

Merged
merged 5 commits into from
Apr 16, 2023
Merged

v.8.7.0 release #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2697dc
v.8.70 release
SathyaBhat Apr 16, 2023
2d0dd03
update Spotify apps dashboard link
SathyaBhat Apr 16, 2023
990c88f
correct spotify dev console link
SathyaBhat Apr 16, 2023
f99049c
Update test_spotify_fetch_tracks.py
SathyaBhat Apr 16, 2023
3dfe6bb
fix tests
SathyaBhat Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions GETTING_STARTED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ You need Python 3.7+. To download songs as MP3, you will need ffmpeg.

pip3 install spotify_dl

1. Login to [Spotify developer console](https://developer.spotify.com/my-applications/#!/applications) and click on "Create an App". Fill in details for name and description
1. Login to [Spotify developer console](https://developer.spotify.com/dashboard) and click on "Create an App". Fill in details for name and description

1. Make a note of Client ID and Client Secret. These values need to be then set `SPOTIPY_CLIENT_ID`, `SPOTIPY_CLIENT_SECRET` environment variables respectively.

Expand All @@ -23,12 +23,14 @@ You need Python 3.7+. To download songs as MP3, you will need ffmpeg.
export SPOTIPY_CLIENT_SECRET=your-spotify-client-secret

Windows Powershell:
$env:SPOTIPY_CLIENT_ID=your-spotify-client-id
$env:SPOTIPY_CLIENT_SECRET=your-spotify-client-secret

$env:SPOTIPY_CLIENT_ID=your-spotify-client-id
$env:SPOTIPY_CLIENT_SECRET=your-spotify-client-secret

Windows CMD:
set SPOTIPY_CLIENT_ID=your-spotify-client-id
set SPOTIPY_CLIENT_SECRET=your-spotify-client-secret

set SPOTIPY_CLIENT_ID=your-spotify-client-id
set SPOTIPY_CLIENT_SECRET=your-spotify-client-secret

See [this question](http://superuser.com/a/284351/4377) for more info,

Expand Down
2 changes: 1 addition & 1 deletion spotify_dl/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

__all__ = ["VERSION"]

VERSION = "8.6.0"
VERSION = "8.7.0"

if os.getenv("XDG_CACHE_HOME") is not None:
SAVE_PATH = os.getenv("XDG_CACHE_HOME") + "/spotifydl"
Expand Down
2 changes: 1 addition & 1 deletion spotify_dl/scaffold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def get_tokens():
set SPOTIPY_CLIENT_SECRET=your-spotify-client-secret

Get your credentials at
https://developer.spotify.com/my-applications
https://developer.spotify.com/dashboard
"""
)
return None
Expand Down
2 changes: 1 addition & 1 deletion tests/test_spotify_fetch_tracks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ def test_spotify_playlist_fetch_more():
"album": "All The Best (Spanish Version)",
"artist": "Zucchero",
"cover": "https://i.scdn.co/image/ab67616d0000b27304e57d181ff062f8339d6c71",
"genre": "classic italian pop",
"name": "You Are So Beautiful",
"num": 18,
"track_url": None,
"genre": "italian adult pop",
"num_tracks": 18,
"year": "2007",
"playlist_num": 5,
Expand Down