Adding a no-overwrites option that avoids re-downloading a song if it already exists locally #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… already exists locally
… we implement our own option instead of delegating
|
@LuluDavid can you address the report from DeepSource, please? https://deepsource.io/gh/SathyaBhat/spotify-dl/run/20ef931f-1b9f-4e01-a65c-4ddad5912d11/python/ |
|
@SathyaBhat Sorry I'm a bit busy these times. I'll work on it this week-end, but it seems kinda unrelated to my changes (maybe they just revealed some ghost warnings that were not triggered for some reason). |
|
thanks @LuluDavid! this is released in v8.0 https://github.com/SathyaBhat/spotify-dl/releases/tag/v8.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the same problem as I mentionned in #209, but I used the built-in --no-overwrites option that exists in yt-dlp.