Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Album Art Cover #145

Merged
merged 12 commits into from
Feb 14, 2021
Merged

Added Album Art Cover #145

merged 12 commits into from
Feb 14, 2021

Conversation

gonzk
Copy link
Contributor

@gonzk gonzk commented Feb 6, 2021

No description provided.

@gonzk
Copy link
Contributor Author

gonzk commented Feb 6, 2021

I had to use urllib to download the cover art.

@SathyaBhat
Copy link
Owner

@gonzk can you please rebase and resolve the conflicts? I can release the new version

@gonzk
Copy link
Contributor Author

gonzk commented Feb 13, 2021

Hi, sorry, I'm not sure what the failing tests are saying. are there conflicts between my files and yours? If so, why would this happen since I did change a few things that were not on your files?

@SathyaBhat
Copy link
Owner

You can ignore the test failure, but will have to fix the merge conflict. This is because I just merged #144 which was based on a different branch as compared to this PR so there are conflicts to be resolved You can see the conflicts here: https://github.com/SathyaBhat/spotify-dl/pull/145/conflicts

@SathyaBhat
Copy link
Owner

see this doc for details if you're having any troubles or not sure how, let me know, I can resolve this for you. Doing it yourself would be a good learning exercise :)

@gonzk
Copy link
Contributor Author

gonzk commented Feb 14, 2021

hi, thank you for being so patient and understanding! I think I figured out how to fix the problems!

@SathyaBhat SathyaBhat merged commit f68da99 into SathyaBhat:master Feb 14, 2021
@SathyaBhat SathyaBhat linked an issue Feb 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Other Metadata Cover
2 participants