-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Album Art Cover #145
Conversation
I had to use urllib to download the cover art. |
@gonzk can you please rebase and resolve the conflicts? I can release the new version |
Hi, sorry, I'm not sure what the failing tests are saying. are there conflicts between my files and yours? If so, why would this happen since I did change a few things that were not on your files? |
You can ignore the test failure, but will have to fix the merge conflict. This is because I just merged #144 which was based on a different branch as compared to this PR so there are conflicts to be resolved You can see the conflicts here: https://github.com/SathyaBhat/spotify-dl/pull/145/conflicts |
see this doc for details if you're having any troubles or not sure how, let me know, I can resolve this for you. Doing it yourself would be a good learning exercise :) |
hi, thank you for being so patient and understanding! I think I figured out how to fix the problems! |
No description provided.