Basic Docker support #141
Merged
Basic Docker support #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a basic Dockerfile so spotify_dl can be shipped as an image
Creating a bash script for parallel bulk downloading of Spotify playlists.
|
per sentry test fails because of invalid client_id because it was triggered by a fork. https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets Let me see if there's ways around this (without doing something like merging in to a "temporary merge" branch in this repo and open another PR) thanks |
|
btw @lucanello can you update the README or GETTING_STARTED guide as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic Dockerfile for building a spotify_dl image and a simple bash script for parallel bulk downloading of Spotify playlists.
Please note: the Dockerfile doesn't need to be changed. The environment variables for the client ID and secret are there for placeholder purposes.
You can choose whether you want them to be included in the self-built Docker image (not suggested!) or you want to pass them when running a container.