Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for importing templates with puppet #9337

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

peterdragun
Copy link
Contributor

Follow-up for #9326

Adding test for importing templates with puppet on sat with puppet enabled and puppet disabled.

Test results:

pytest -v tests/foreman/api/test_templatesync.py -k test_import_template_with_puppet
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.9.9, pytest-6.2.5, py-1.10.0, pluggy-0.13.1 -- /home/pdragun/.virtualenvs/robottelo/bin/python
cachedir: .pytest_cache
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/pdragun/Documents/robottelo, configfile: pyproject.toml
plugins: cov-2.12.1, forked-1.3.0, services-2.2.1, reportportal-5.0.8, mock-3.6.1, xdist-2.5.0, ibutsu-2.0.2
collected 31 items / 29 deselected / 2 selected                                                                                                                                                                                              

tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_import_template_with_puppet[puppet_enabled] PASSED                                                                                                              [ 50%]
tests/foreman/api/test_templatesync.py::TestTemplateSyncTestCase::test_import_template_with_puppet[puppet_disabled] PASSED                                                                                                             [100%]

========================================================================================== 2 passed, 29 deselected, 1 warning in 2705.35s (0:45:05) ==========================================================================================

@peterdragun peterdragun added API Issues and PRs involving the API 7.0 labels Jan 28, 2022
@peterdragun peterdragun requested a review from ogajduse January 28, 2022 14:06
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left one minor comment.

@vsedmik Can you please do a review from the Puppet standpoint?

tests/foreman/api/test_templatesync.py Outdated Show resolved Hide resolved
@ogajduse ogajduse requested a review from vsedmik January 31, 2022 13:39
@peterdragun
Copy link
Contributor Author

peterdragun commented Jan 31, 2022

CI failed on installing dependencies, seems not related to this PR as it succeeded on first run and only change since then was renaming variable as suggested.

Update: CI is already fixed in #9341

Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, nice parametrization through enabled/disabled sat!

@ogajduse ogajduse merged commit 69dc772 into SatelliteQE:master Feb 1, 2022
@tstrych tstrych added 6.11.z Introduced in or relating directly to Satellite 6.11 and removed 7.0 labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z Introduced in or relating directly to Satellite 6.11 API Issues and PRs involving the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants