Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model ID Not Defined #3190

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Model ID Not Defined #3190

merged 2 commits into from
Jan 24, 2025

Conversation

jamescrake-merani
Copy link
Contributor

Description

For some reason, a commit seems to have been left out of #3160 which leads to an error whenever a plot is created. I think this may have been a mistake I made when cherry picking commits so I could rebase the branch onto release 6.0.1. I may have inadvertently left out the first commit.

Fixes #3159

How Has This Been Tested?

I have followed the reproduction steps mentioned in the original issue, and I am not able to reproduce the bug anymore.

Review Checklist:

Documentation

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue and code looks fine.

@wpotrzebowski wpotrzebowski merged commit 40adfc6 into release_6.0.1 Jan 24, 2025
40 checks passed
@wpotrzebowski wpotrzebowski deleted the model_id_not_defined branch January 24, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants