Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2741: Fix PD parameter issue #2991

Merged
merged 3 commits into from
Aug 2, 2024
Merged

2741: Fix PD parameter issue #2991

merged 3 commits into from
Aug 2, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Jul 25, 2024

Description

A change to the PD params resulted in width, npts, and nsigmas to all change width of the underlying model. This corrects that behavior.

Fixes #2741

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@wpotrzebowski wpotrzebowski added SasView 6.0.0 Required for 6.0.0 release Discuss At The Call Issues to be discussed at the fortnightly call labels Jul 27, 2024
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to reproduce the issue, so can't say this fixes the problem, but the code looks OK.

src/sas/qtgui/Perspectives/Fitting/FittingWidget.py Outdated Show resolved Hide resolved
@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Aug 1, 2024
@krzywon krzywon merged commit 5a71495 into release_6.0.0 Aug 2, 2024
28 checks passed
@krzywon krzywon deleted the 2741-pd-params branch August 2, 2024 13:48
@krzywon krzywon mentioned this pull request Aug 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants