2875 drop logger level required to force log explorer to pop up from error to warning #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzywon
approved these changes
May 9, 2024
There was a problem hiding this comment.
I tested this locally by trying to save an empty analysis. The log opened when the warning was thrown. Thanks for removing unneccessary passes.
Two suggestions:
- The inline comment above
record.levelnosays to show the log if error or worse. This should be updated to prevent confusion in the future. - Remove 3 empty lines where
passused to be (lint).
We need to run black on the whole thing at some point soon. Think there is an issue for it. |
butlerpd
deleted the
2875-drop-logger-level-required-to-force-log-explorer-to-pop-up-from-error-to-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log view shows on level 30 now instead of 40.
Removed unnecessary passes