Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving OSX signing to nightly #2631

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Moving OSX signing to nightly #2631

merged 1 commit into from
Sep 21, 2023

Conversation

wpotrzebowski
Copy link
Contributor

Description

Moving OSX signing to nightly builds, so that builds work from forks

Fixes # (issue/issues)

How Has This Been Tested?

Install builds from PR and nightly

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • The introduced changes comply with SasView license (BSD 3-Clause)

rozyczko
rozyczko approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe and the only way to make sure it's working as designed is merging with main. Let's do it then

@wpotrzebowski wpotrzebowski merged commit af54d02 into main Sep 21, 2023
@wpotrzebowski wpotrzebowski deleted the gh_action_cleanup branch September 21, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozyczko rozyczko rozyczko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpotrzebowski @rozyczko