Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid lines toggle for standard Plot1D #2630

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Grid lines toggle for standard Plot1D #2630

merged 2 commits into from
Sep 22, 2023

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Sep 20, 2023 •
edited by astellhorn
Loading

Description

Added grid lines on Plot1D, similar to those on QuickPlot. Access through the context menu.

Fixes @smk78 's complaint

How Has This Been Tested?

Locally on win10

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)

@rozyczko rozyczko requested a review from smk78 September 20, 2023 16:57
@wpotrzebowski
Copy link
Contributor

Right click doesn't seem to work on Mac:
18:09:42 - ERROR: Traceback (most recent call last): File "sas/qtgui/Plotting/PlotterBase.py", line 272, in showContextMenu File "sas/qtgui/Plotting/Plotter.py", line 316, in createContextMenu File "sas/qtgui/Plotting/Plotter.py", line 397, in addPlotsToContextMenu ValueError: operands could not be broadcast together with shapes (174,) (0,)

astellhorn
astellhorn approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@astellhorn astellhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on the windows GUI

@lucas-wilkins lucas-wilkins merged commit f476bad into main Sep 22, 2023
@lucas-wilkins lucas-wilkins deleted the grid_on_plot branch September 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astellhorn astellhorn astellhorn approved these changes

@smk78 smk78 Awaiting requested review from smk78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rozyczko @wpotrzebowski @astellhorn @lucas-wilkins @krzywon