Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local documentation generation #2576

Merged
merged 161 commits into from
Jan 16, 2024
Merged

Conversation

tsole0
Copy link
Contributor

@tsole0 tsole0 commented Aug 2, 2023

Description

WORK IN PROGRESS

Overhauls documentation viewing and editing system. When 'Help' is pressed anywhere in SasView, a window now appears that displays documentation using QT's WebViewEngine widget. This window also has buttons to edit the documentation, which will pull up the relevant RST (if user documentation) or Python file (if a model). When the 'Save' button is pressed, the relevant documentation is regenerated using a python to RST converter (if a model) and a somewhat skimmed-down version of Sphinx. A refresh of any open documentation windows is then triggered upon completion of the regeneration, displaying the user's changes. User-created documentation will also be generated and will display when 'Help' is pressed.

Sphinx will need to be included as a dependency for this update to work.

TODO
Fix various bugs, and, importantly, make sure the required files get ported over to the installed version and everything works on installed version.

Fixes #706

How Has This Been Tested?

Waiting for fixing of final bugs before describing

Review Checklist:

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • User documentation is available and complete
  • Developers documentation is available and complete - NOTE: developer documentation does not regenerate
  • The introduced changes comply with SasView license (BSD 3-Clause)

tsole0 added 30 commits June 23, 2023 16:45
Regeneration of HTML succeeds using Makefile *but* doctree not
generating correctly for models.
(also added explanation to currently not in use make command)
…O fix filepaths so that makedocumentation runs
…xes error passing in single argument to regenmodel
@wpotrzebowski
Copy link
Contributor

It seems that this PR is failing at the notarization step. I am looking into more details

@wpotrzebowski
Copy link
Contributor

It seems that some of Qt folders/modules are not signed. I am not sure but we may need to include more folder in fix_qt_folders script

@wpotrzebowski
Copy link
Contributor

Here is the log:
notarization_log.txt

@krzywon krzywon marked this pull request as ready for review January 16, 2024 20:24
@butlerpd butlerpd merged commit 9e3698b into release_6.0.0 Jan 16, 2024
32 of 34 checks passed
@butlerpd butlerpd deleted the local-documentation-generation branch January 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Concerns documentation Enhancement Feature requests and/or general improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make model help available for custom models (Trac #574)
8 participants