[Release 5.0.6] Cherry-picked 2178 - Breaking bug in P(r) #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not clear to me that this should be merged to 5.0.6. Reviewing the PR it comes from and the issue that generated the PR it seems that the breaking comes from an upgrade to the numpy version used by main. I guess the question is how many of the dependencies get updated here? That said it should not be a problem to merge it I guess since it just bypasses the deprecated |
butlerpd
added
Discuss At The Call
butlerpd
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of what is to be many PRs for the release of 5.0.6. This is a cherry-pick of the single commit in #2178 to fix broken P(r) inversion functionality and unit tests.