Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plot legend not updating on custom change. #2361 #2362

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix plot legend not updating on custom change. #2361 #2362

merged 1 commit into from
Oct 31, 2022

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Oct 31, 2022 •
edited by wpotrzebowski
Loading

Fixes #2361 after changes in 74358e2

How Has This Been Tested?

Testing description in the issue

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • The introduced changes comply with SasView license (BSD 3-Clause)

@rozyczko rozyczko requested a review from smk78 October 31, 2022 20:37
@wpotrzebowski wpotrzebowski self-requested a review October 31, 2022 20:56
wpotrzebowski
wpotrzebowski approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Mac

smk78
smk78 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality test on x64/W10. Can change the data label again!

@wpotrzebowski wpotrzebowski merged commit 5e00d90 into main Oct 31, 2022
@wpotrzebowski wpotrzebowski deleted the 2361_plot_legend branch October 31, 2022 21:32
@krzywon krzywon mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpotrzebowski wpotrzebowski wpotrzebowski approved these changes

@lucas-wilkins lucas-wilkins lucas-wilkins approved these changes

@smk78 smk78 smk78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot legend can't be changed
4 participants
@rozyczko @wpotrzebowski @lucas-wilkins @smk78