Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sesans debugging #2318

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Sesans debugging #2318

merged 3 commits into from
Oct 28, 2022

Conversation

caitwolf
Copy link
Contributor

This removes the deep copying of the model that occurs during fitting and allows the plots to update with changes after fitting. This deepcopy was done by @rozyczko so he should probably check that it is fine to remove.

This should close #1998 - This was also a problem for non-sesans data but was more apparent when working in the sesans correlation space, making it seem that the plots were not updating after fitting for sesans data only.

@rozyczko
Copy link
Member

This deepcopy goes back A LONG time, to 2018, where I was fixing an old bug in polydispersity behaviour.
This seems to have been a leftover from that exercise. The target bug does not occur anymore with the removed deepcopy so I assume it got resolved/hidden elsewhere over the years.
As such, I think removal of the deepcopy is benign and if it fixes the issue, should be merged.

@rozyczko
Copy link
Member

rozyczko commented Oct 28, 2022

For the sake of tracking the issue:
these two bugs are linked to the change from 2018 (viewable only to ESS staff)
https://jira.esss.lu.se/browse/SASVIEW-1008
https://jira.esss.lu.se/browse/SASVIEW-1013

Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to fix the problem and a quick check of my standard 1D fitting also still works and the fact that this may also have been a minor issue for 1D fitting, I think this should be merged post haste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.x: Changing parameter in FitPage does not update plot when fitting SESANS data
4 participants