-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt 5.15.4 compatibility #2214
Qt 5.15.4 compatibility #2214
Conversation
I've tested running it from installer on Mac and SasView crashes on start. After some debugging the problem seems to be related to setuptools._distutils:
|
Maybe that's what it is fixed with #2216? |
@wpotrzebowski, no, that's #2222 and unrelated to this PR. The solution is to either upgrade setuptools or upgrade matplotlib (or both). |
Interestingly, on Windows, PyQt ver. 5.15.7 comes with Qt 5.15.2
The changes proposed seem to work fine, though. I assume when Windows Qt versioning catches up with Linux, all should be fine as well. |
@wpotrzebowski and @rozyczko will test it before merging |
Rebased to current main so that CI can regenerate the installers with the setuptools fixes in them. |
At some point the jump to PyQt6 might have to be made. There are no PyQt5 wheels for I would imagine this issue would become more pressing as more people transition to M series chips from x86_64. Do most users install dependencies via pip or conda? |
|
@rozyczko or @pbeaucage will look at this with a windows machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on Windows.
This PR attempts to improve compatibility with newer Qt/PyQt releases. Several functions regarding progress bar values and pixel positioning that used to accept
float
now only acceptint
. The C++ Qt documentation for these functions uniformly says that the arguments should beint
; I'm not sure whether the failures observed are due to changes in Qt or PyQt, and they may even be architecture-specific.I expect that there are more changes like these needed, as I found these spots just by wandering through the interface loading dialogues and hitting "fit" or "compute" buttons.
Platform: Linux (Debian)
Python: 3.10
Qt: 5.15.7
PyQt: 5.15.4