Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings in perspective.py #2207

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Docstrings in perspective.py #2207

merged 2 commits into from
Sep 16, 2022

Conversation

lucas-wilkins
Copy link
Contributor

Added docstrings to perspective.py where they were missing.

@lucas-wilkins lucas-wilkins added Minor Small job Documentation Concerns documentation labels Sep 15, 2022
@lucas-wilkins lucas-wilkins linked an issue Sep 15, 2022 that may be closed by this pull request
Complete doc strings in perspective.py #2206
Closed
krzywon
krzywon requested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the spelling and it's good to go

smk78
smk78 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@smk78 smk78 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings seem to tally with the intention of the methods/flags.

@krzywon krzywon merged commit 8388076 into main Sep 16, 2022
@krzywon krzywon deleted the 2206-complete-doc-strings-in-perspectivepy branch September 20, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk78 smk78 smk78 approved these changes

@krzywon krzywon krzywon approved these changes

@butlerpd butlerpd Awaiting requested review from butlerpd

@ru4en ru4en Awaiting requested review from ru4en

Assignees
No one assigned
Labels
Documentation Concerns documentation Minor Small job
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete doc strings in perspective.py
3 participants
@lucas-wilkins @smk78 @krzywon