-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update list of coordinate testdata file #2148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't speak for the information given about the new files, but the formatting looks fine and the docs build properly.
@krzywon Was there a reason not to merge this? Feel like there might have been, but it's been here a while. |
I thought someone should review the content of the text before merging, otherwise, no. |
Unless its factually incorrect, it looks fine. |
The factual correctness is what I want someone to review. |
1) Is there anyone other than @dehoni, the author, that's in a position to
do that?
2) If there is, what's the chance that they actually will do it?
…On Thu, 15 Sept 2022, 15:14 Jeff Krzywon, ***@***.***> wrote:
@krzywon <https://github.com/krzywon> Was there a reason not to merge
this? Feel like there might have been, but it's been here a while.
I thought someone should review the content of the text before merging,
otherwise, no.
Unless its factually incorrect, it looks fine.
The factual correctness is what I want someone to review.
—
Reply to this email directly, view it on GitHub
<#2148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKU4SQLS4CP7FFWSK2FLVTV6MVNRANCNFSM56WBLCLQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptions look fine to me.
No description provided.