Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update list of coordinate testdata file #2148

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Conversation

dehoni
Copy link
Contributor

@dehoni dehoni commented Aug 16, 2022

No description provided.

@dehoni dehoni linked an issue Aug 16, 2022 that may be closed by this pull request
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the information given about the new files, but the formatting looks fine and the docs build properly.

@wpotrzebowski wpotrzebowski added Discuss At The Call Issues to be discussed at the fortnightly call and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Aug 29, 2022
@lucas-wilkins
Copy link
Contributor

See #2176 for why your tests are failing, merge the associated branch for fix, or merge main when #2178 is merged in.

@lucas-wilkins
Copy link
Contributor

@krzywon Was there a reason not to merge this? Feel like there might have been, but it's been here a while.

@krzywon
Copy link
Contributor

krzywon commented Sep 14, 2022

@krzywon Was there a reason not to merge this? Feel like there might have been, but it's been here a while.

I thought someone should review the content of the text before merging, otherwise, no.

@lucas-wilkins
Copy link
Contributor

@krzywon Was there a reason not to merge this? Feel like there might have been, but it's been here a while.

I thought someone should review the content of the text before merging, otherwise, no.

Unless its factually incorrect, it looks fine.

@krzywon
Copy link
Contributor

krzywon commented Sep 15, 2022

@krzywon Was there a reason not to merge this? Feel like there might have been, but it's been here a while.

I thought someone should review the content of the text before merging, otherwise, no.

Unless its factually incorrect, it looks fine.

The factual correctness is what I want someone to review.

@lucas-wilkins
Copy link
Contributor

lucas-wilkins commented Sep 15, 2022 via email

Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions look fine to me.

@krzywon krzywon merged commit 65d855c into main Sep 16, 2022
@krzywon krzywon deleted the add-magnetic-test-files branch September 20, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give files in test folder descriptive names
5 participants